-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More Functional Parsing DSL API. #324
Labels
Comments
This may have a slight performance impact, should be measured. |
bd82
added a commit
that referenced
this issue
Dec 11, 2016
relates to #324 Includes some performance Optimizations for *_SEP DSL methods.
bd82
added a commit
that referenced
this issue
Dec 11, 2016
relates to #324 * Includes some performance Optimizations for *_SEP DSL methods. * Includes updates for performance guidelines docs.
Performance impact was very small and was mostly mitigated with some optimizations. |
Breaking Changes:This change broke a few APIS:
|
bd82
added a commit
that referenced
this issue
Dec 12, 2016
relates to #324 * Includes some performance Optimizations for *_SEP DSL methods. * Includes updates for performance guidelines docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Some of this was suggested in the past by @Zumbala
#215 (comment)
All the parsing DSL methods should return a value.
Currently this is only true for OR and CONSUME
but it should also be applied to:
The _SEP variants should return two arrays, one of the separator tokens and one of the values.
The text was updated successfully, but these errors were encountered: