Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagrams drawing bug when using custom Token patterns. #462

Closed
MrLeebo opened this issue May 1, 2017 · 2 comments
Closed

Diagrams drawing bug when using custom Token patterns. #462

MrLeebo opened this issue May 1, 2017 · 2 comments

Comments

@MrLeebo
Copy link

MrLeebo commented May 1, 2017

If you try to render the diagram for a parser that contains a custom pattern function, the diagram fails to render.

Repro steps:

  1. Visit the playground
  2. Change a token to a custom token function, such as var True = createToken({name: "True", pattern: t => null});
  3. 💥
Errors during evaluation of the implementation: 
this.children.forEach is not a function
@bd82
Copy link
Member

bd82 commented May 1, 2017

Gracias. 👍

I will look into this.

@bd82 bd82 added the webpage label May 1, 2017
@bd82 bd82 changed the title Playground fails on custom pattern functions Diagrams drawing bug when using custom Token patterns. May 1, 2017
@bd82 bd82 added the Bug 🪲 label May 1, 2017
@bd82 bd82 closed this as completed in 4fc4b1f May 1, 2017
@bd82
Copy link
Member

bd82 commented May 1, 2017

Will release a version with this fix soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants