-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove automatic collection of return values for iterations #784
Comments
While it does not make much sense to collect the iteration results when building a CST. Perhaps it would be possible to optionally collect the iteration results only in embedded actions mode? |
After some more thinking I've decided to remove the automatic result collection completely because:
Conditionally enabling / disabling the results collection is likely possible but the added Keeping all the DSL methods as expressions (returns something) is also purer in a theoretical sense, |
Breaking changes will be tracked in |
The iterations DSL methods (MANY/AT_LEAST_ONE and _SEP variants)
automatically collect the return values of all iterations and return an array.
This causes some problems:
perhaps even collecting an array of "undefined" values.
Need to investigate if anyone actually uses these APIs.
And if they will be removed also update relevant docs.
The text was updated successfully, but these errors were encountered: