Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No mention of 'resource' in list at verify_refers_to #22

Open
RvanVeenendaal opened this issue Mar 9, 2020 · 2 comments
Open

No mention of 'resource' in list at verify_refers_to #22

RvanVeenendaal opened this issue Mar 9, 2020 · 2 comments
Labels

Comments

@RvanVeenendaal
Copy link

According to the WARC 1.0 and 1.1 specifications "[t]he WARC-Refers-To field shall not be used in ‘warcinfo’, ‘response’, ‘resource’, ‘request’, and ‘continuation’ records".
In warcat's source code, verify_refers_to does not mention 'resource'.
Is this a bug or a feature?

if record.warc_type in ('warcinfo', 'response', 'request',

@chfoo
Copy link
Owner

chfoo commented Mar 10, 2020

Good catch, it's not supposed to be missing that one.

(As a FYI, this project was written based on the draft WARC 1.0 spec. I haven't updated the project since then, but in this case, I must have missed it by accident.)

@chfoo chfoo added the bug label Mar 10, 2020
@billsargent
Copy link

Is it enough to simply add in the missing 'resource'?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants