Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Timestamps do not work right with local files #82

Closed
dumka opened this issue Jul 26, 2023 · 2 comments · Fixed by #83
Closed

[Bug] Timestamps do not work right with local files #82

dumka opened this issue Jul 26, 2023 · 2 comments · Fixed by #83

Comments

@dumka
Copy link
Contributor

dumka commented Jul 26, 2023

Hello. First of all, thanks for the awesome plugin. Besides podcasts, I also wanted to use it for audiobooks listening. The problem is that when I am listening to a local file with audiobook I make captures, but after I finish the listening all links from timestamps suddenly stop working - they just do nothing. However. if I manually start the same file to play once more these links start working again. I would be very grateful for the fix.
@dumka
Copy link
Contributor Author

dumka commented Jul 31, 2023

The issue happened because files containing space in their name and/or paths were not processed correctly. Pull request with a fix was prepared #83 .

@chhoumann
Copy link
Owner

Hey @dumka, thanks for making the PR! I just merged it in.

@chhoumann chhoumann linked a pull request Jul 31, 2023 that will close this issue
Fix spaces in a url and local file name #83
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix spaces in a url and local file name dumka/PodNotes
2 participants
@dumka @chhoumann