Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not iOS 5 compatible #4

Closed
gsempe opened this issue Feb 6, 2013 · 6 comments
Closed

Not iOS 5 compatible #4

gsempe opened this issue Feb 6, 2013 · 6 comments

Comments

@gsempe
Copy link

gsempe commented Feb 6, 2013

It's not possible to use it on iOS5. Several points:

  • UICollectionViewDelegate and UICollectionViewLayout do not exist on iOS5
  • When used with PSTCollectionView on iOS5 it raises an exception when PSTCollectionView tries to put itself in collectionView property of the layout.
@chiahsien
Copy link
Owner

Hi there,

  1. Of course, so you need PSTCollectionView.
  2. Never heard of it. It works fine on my iOS 5 simulator, maybe you need to check PSTCollectionView's samples a little bit further. In my memories, PSTCollectionView not yet works fine with Storyboard.

@chiahsien
Copy link
Owner

PSTCollectionView has many updates recently, maybe you could give it a try 😄

@gsempe
Copy link
Author

gsempe commented Feb 20, 2013

CollectionViewWaterfallLayout also use UICollectionViewLayoutAttributes internally. I can't get how it can work on iOS 5.1. It seems I'm missing something if you can get it works

@chiahsien
Copy link
Owner

  1. You need PSTCollectionView, then
  2. Change UICollectionViewLayoutAttributes to PSUICollectionViewLayoutAttributes manually.

It can't work on iOS 5.1 without PSTCollectionView. 😄

@gsempe
Copy link
Author

gsempe commented Mar 5, 2013

I have your collection view layout working on iOS 5.1 since the beginning but it needs internal code changing to work on iOS < 6. The point I would raise with the issue it that the waterfall flow layout is not iOS5 compatible out of the box. Anyway it is a good implementation which works very well. Thank you

@gsempe gsempe closed this as completed Mar 5, 2013
@gsempe gsempe reopened this Mar 5, 2013
@chiahsien
Copy link
Owner

Maybe I should provide more descriptions in the readme file.
Thanks for your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants