Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version 0.3.1 is not compatible with DRF 3.8 and produces ImportError #226

Closed
jberends opened this issue Jun 18, 2018 · 15 comments
Closed

Comments

@jberends
Copy link

The version 0.3.1 is not compatible with DRF 3.8. It seems that the master is, but the latest provided release to PyPI apparently not.

It produces an import error in the 0.3.1 code

Error:

  ...
  File ".../site-packages/rest_framework_extensions/routers.py", line 7, in <module>
    from rest_framework.routers import (
ImportError: cannot import name 'replace_methodname'

Culprit code of 0.3.1

# -*- coding: utf-8 -*-
from distutils.version import StrictVersion
from django.core.exceptions import ImproperlyConfigured
from django.core.urlresolvers import NoReverseMatch

import rest_framework
from rest_framework.routers import (
    DefaultRouter,
    SimpleRouter,
    Route,
    replace_methodname,
    ^^^^^^^^^^^^^^^^^^^
)
@travis-cramer
Copy link

I've run into the same error. Running drf 3.8.2

@auvipy
Copy link
Collaborator

auvipy commented Jul 12, 2018

you need to install from master master support 3.8

@SultanSGillani
Copy link

It still would be nice to get this in pypy.

@jberends
Copy link
Author

jberends commented Jul 13, 2018 via email

@auvipy
Copy link
Collaborator

auvipy commented Jul 15, 2018

lack of time

@jberends
Copy link
Author

Is there anything that we can help you with?
Maybe automate the build and upload of packages eg. using twine

I can make a PR...

pip install twine
python setup.py bdist_wheel --universal
twine upload dist/*.whl

@auvipy
Copy link
Collaborator

auvipy commented Jul 16, 2018

need to revert one commit and some release notes remain actually

@bryson
Copy link

bryson commented Aug 1, 2018

Can you add instructions for installing from git to the README at least?

@auvipy
Copy link
Collaborator

auvipy commented Aug 12, 2018

I will

@adrienrusso
Copy link

adrienrusso commented Sep 6, 2018

Same issue here, Still waiting for a new version.
Do you have an ETA?

@auvipy
Copy link
Collaborator

auvipy commented Sep 6, 2018

i have emailed the original author for a new pypi release.

@adrienrusso
Copy link

0.4.0 has been released 15 hours ago. Thanks

@auvipy
Copy link
Collaborator

auvipy commented Sep 12, 2018

please let me know if the pypi release is working well. it's my first release of this package

@auvipy auvipy closed this as completed Sep 12, 2018
@adrienrusso
Copy link

I have no issue so far. It passes all our checks.

@auvipy
Copy link
Collaborator

auvipy commented Sep 12, 2018

awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants