Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made compatible with DRF 3.2.2 and django 1.8 #99

Merged
merged 14 commits into from Dec 1, 2015
Merged

Made compatible with DRF 3.2.2 and django 1.8 #99

merged 14 commits into from Dec 1, 2015

Conversation

pratyushmittal
Copy link
Contributor

Hi Gennady,

I have made a few changes to make drf-extensions compatible with the latest Django Rest Framework. The new versions of Django Rest Framework, since 3.1.0, have introduced some breaking changes, such as the new Pagination classes. The tests pass with these recent versions only.

How about considering to drop the support for earlier versions? We can add some note like:

For Django Rest Framework 2.4 support check drf-extensions 0.2.7

Thanks for creating and sharing the extensions.

@rocjojo
Copy link

rocjojo commented Oct 26, 2015

Hello,

Any news about that ? I'm struggling with pagination as well...

@codingjoe
Copy link
Contributor

👍 support for the latest DRF version would be great!

@auvipy
Copy link
Collaborator

auvipy commented Nov 11, 2015

@pratyushmittal hi thanks for your works, would u mind restesting and rebasing against drf 3.3.1?

@auvipy
Copy link
Collaborator

auvipy commented Nov 11, 2015

should consider this #113

@auvipy
Copy link
Collaborator

auvipy commented Nov 30, 2015

@pratyushmittal would you please update the PR to pass the CI build?

@pratyushmittal
Copy link
Contributor Author

Hi @auvipy , it is good to see the reincarnation of this awesome library.

In the pull request, I have dropped the support of old DRF versions (due to the new Pagination Class implementation). I have also included new tests for this. Travis CI is still building against the old tests. Any workaround to see the Travis results for the new tests included?

@auvipy
Copy link
Collaborator

auvipy commented Dec 1, 2015

thanks for your effort. will check CI n your code. I'm also planning to drop support of older versions of DRF and django itself too

@codingjoe
Copy link
Contributor

👍 and old python versions ;)
py3

@auvipy
Copy link
Collaborator

auvipy commented Dec 1, 2015

@codingjoe python 2.7, 3.4 and 3.5 will be supported as django supports them.

@pratyushmittal
Copy link
Contributor Author

I have updated the Tox file to test against the latest, LTS and supported python versions.

@auvipy
Copy link
Collaborator

auvipy commented Dec 1, 2015

you need to update travis.yml too :) and keep support of 1.7 for now :)

@pratyushmittal
Copy link
Contributor Author

All the tests are passing except for Django 1.7 on Python 3.5. Django 1.7 did not support 3.5.

@codingjoe
Copy link
Contributor

This should do it
travis.yml

matrix:
  allow_failures:
    - env: DJANGO="Django<1.8,>=1.7"
      python: "3.5"

The hash algorithm used for caching of key constructor was sha256.
SHA256 is inherently meant to be slow as it is meant for security use-cases.
For caching we need a faster hash generation only for unique keys.
NGINX uses md5 for cache keys.
@pratyushmittal
Copy link
Contributor Author

@codingjoe Thanks. Have excluded Django1.7 for Python 3.5 tests.

I have also changed the hash algorithm used for caching of key constructor from sha256 to md5.
SHA256 is inherently meant to be slow as it is meant for security use-cases.
For caching we need a faster hash generation only for unique keys.
NGINX uses md5 for cache keys.

@auvipy
Copy link
Collaborator

auvipy commented Dec 1, 2015

thanks @pratyushmittal for your works! @codingjoe for your insights!! ;)

auvipy added a commit that referenced this pull request Dec 1, 2015
made the package compatible with latest version of django-rest-framework and django 1.8lts and python 3.5, dropped support for obsolete versions of python, django and django-rest-framework.
@auvipy auvipy merged commit d08425c into chibisov:master Dec 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants