Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support RTL in seeking Slider #21

Closed
MoElnaggar14 opened this issue Dec 25, 2020 · 13 comments · Fixed by #22
Closed

Support RTL in seeking Slider #21

MoElnaggar14 opened this issue Dec 25, 2020 · 13 comments · Fixed by #22

Comments

@MoElnaggar14
Copy link

MoElnaggar14 commented Dec 25, 2020

Describe the bug
seeking is scrolling in the opposite direction in RTL.

To Reproduce

  1. Using RangUISlider in App Support RTL.

Expected behaviour
seeking should work from RTL for min and LTR for max.

@chicio
Copy link
Owner

chicio commented Dec 27, 2020

Hi @MoElnaggar14 , thank you for your feedback. I will work on this in the following days. I will let you know when a pull request is ready

In the meantime you can support my work by ⭐️ starring ⭐️ the repository.

Thanks,
Fabrizio.

@chicio chicio added this to To do in RangeUISlider Dec 27, 2020
@chicio chicio moved this from To do to In progress in RangeUISlider Dec 27, 2020
@chicio
Copy link
Owner

chicio commented Dec 27, 2020

Hi @MoElnaggar14 ,

I'm here again to tell you that I implemented the feature you asked in this issue (it was quicker than I was expecting 😅). Can you test the code contained in the pull request below and try the new stuff to see if it works as you expect?

Add support for RTL (Closes #21) #22

After your confirmation, I will release a new version of RangeUISlider.

Thanks,
Fabrizio.

@MoElnaggar14
Copy link
Author

Hello @chicio,
Thank you for the quick implementation for this feature.

cool, I'll test it today and back to you in #22

Thanks

@MoElnaggar14
Copy link
Author

Screen.Recording.2020-12-27.at.10.15.35.PM.mov

I just tested the #22. Unfortunately, it's the same results

@chicio
Copy link
Owner

chicio commented Dec 28, 2020

Hi @MoElnaggar14 , sorry to hear that 😔. I think I misunderstood the problem. I will work on it today and I will let you know when I have something ready.

@chicio
Copy link
Owner

chicio commented Dec 28, 2020

Hi @MoElnaggar14 , I made the fix. If you test again the code in the pull request I sent you before you should get the expected behaviour. Attached here you can find also a video that show the demo project running in simulated RTL mode where RangeUISlider works as expected.

Screen.Recording.2020-12-28.at.10.48.18.mov

@MoElnaggar14
Copy link
Author

Hi @chicio
I'll test it today. I really appreciate your quick response.

Thank,
Mohammed

@chicio chicio moved this from In progress to Code Review in RangeUISlider Dec 28, 2020
@chicio chicio linked a pull request Dec 30, 2020 that will close this issue
4 tasks
@chicio
Copy link
Owner

chicio commented Jan 1, 2021

Hi @MoElnaggar14 and happy new year 🎊!! Did you have the time to try out the PR code with the new implementation?

Thanks,
Fabrizio.

@MoElnaggar14
Copy link
Author

Happy new year @chicio , wishing you the best.

Absolutely, i'll do it today and keep you updated 🙏🏻

@chicio
Copy link
Owner

chicio commented Jan 2, 2021

@MoElnaggar14 Any news?

@MoElnaggar14
Copy link
Author

Testing, just a sec

@MoElnaggar14
Copy link
Author

Hi @chicio , sorry for the late test.

Awesome 👏looks good and works fine.

@chicio
Copy link
Owner

chicio commented Jan 2, 2021

Thank you @MoElnaggar14 🙏. I will prepare a new release in the afternoon 🚀🚀

chicio added a commit that referenced this issue Jan 3, 2021
@chicio chicio moved this from Code Review to Done in RangeUISlider Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

2 participants