-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support RTL in seeking Slider #21
Comments
Hi @MoElnaggar14 , thank you for your feedback. I will work on this in the following days. I will let you know when a pull request is ready In the meantime you can support my work by ⭐️ starring ⭐️ the repository. Thanks, |
Hi @MoElnaggar14 , I'm here again to tell you that I implemented the feature you asked in this issue (it was quicker than I was expecting 😅). Can you test the code contained in the pull request below and try the new stuff to see if it works as you expect? Add support for RTL (Closes #21) #22 After your confirmation, I will release a new version of RangeUISlider. Thanks, |
Screen.Recording.2020-12-27.at.10.15.35.PM.movI just tested the #22. Unfortunately, it's the same results |
Hi @MoElnaggar14 , sorry to hear that 😔. I think I misunderstood the problem. I will work on it today and I will let you know when I have something ready. |
Hi @MoElnaggar14 , I made the fix. If you test again the code in the pull request I sent you before you should get the expected behaviour. Attached here you can find also a video that show the demo project running in simulated RTL mode where RangeUISlider works as expected. Screen.Recording.2020-12-28.at.10.48.18.mov |
Hi @chicio Thank, |
Hi @MoElnaggar14 and happy new year 🎊!! Did you have the time to try out the PR code with the new implementation? Thanks, |
Happy new year @chicio , wishing you the best. Absolutely, i'll do it today and keep you updated 🙏🏻 |
@MoElnaggar14 Any news? |
Testing, just a sec |
Hi @chicio , sorry for the late test. Awesome 👏looks good and works fine. |
Thank you @MoElnaggar14 🙏. I will prepare a new release in the afternoon 🚀🚀 |
Describe the bug
seeking is scrolling in the opposite direction in RTL.
To Reproduce
Expected behaviour
seeking should work from RTL for min and LTR for max.
The text was updated successfully, but these errors were encountered: