Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent teams from issuing feedback for silent rounds #36

Open
philipbelesky opened this issue Jan 2, 2017 · 4 comments
Open

Prevent teams from issuing feedback for silent rounds #36

philipbelesky opened this issue Jan 2, 2017 · 4 comments

Comments

@philipbelesky
Copy link
Contributor

philipbelesky commented Jan 2, 2017

Apologies for the open ended feature request. I also don't have a dev environment working atm where I can replicate things so I'm adding this with 100% certainty that this already isn't the case and I've misunderstood something.

Anyway, from what I could tell from Dutch Worlds it seems like teams can enter feedback on their judges during silent rounds.

@chief-nerd
Copy link
Owner

Yes that is true - currently there is not such thing in Tabbie2 like a silent round. This would have to be implemented as a flag in the database is_silent or so. Then the feedback could be deactivated based on this flag that the Tab Team sets in the create Round

@rscoates
Copy link
Collaborator

rscoates commented Jan 6, 2017

I actually disagree with this - a number of teams at WUDC wanted to submit feedback on their judges during silent rounds (usually ESL/EFL teams wanting to say that the judge in their live, but Open break dead, room looked disinterested) and assumed they couldn't. In fact, it was discussed at Council that they wanted to leave it in. I'd really rather not complicate matters by taking this out.

@philipbelesky
Copy link
Contributor Author

Ah that seems fair. Should I close this "wont fix" or perhaps there might be some later need to mark silent rounds that this could be re-appropriated for?

@rscoates
Copy link
Collaborator

I think having a 'silent round' tag is a good idea, especially for displaying info on the judge's interface, and I suppose you could disable feedback for these rounds, but I wouldn't have it in by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants