multiplied bindings

[ujovlado]

Hi, we'reusing angular-hotkyes in our project.

On site index we have welcome page, on another site home there are some actions with added hotkeys.

When I navigate from index to home and show help through ? everything is fine. Then I navigate to index and back to home and keys are doubled (then tripled, ... etc.)

[chieffancypants]

They shouldn't be -- there are test cases to prevent that. Are you defining the hotkeys through the routing? You may just be setting up persistent hotkeys.

[ujovlado]

Hi, thanks for response. Hotkeys are defined only in one controller, because only in that controller are needed. But I used ui-router (https://github.com/angular-ui/ui-router), maybe that causing a problem. I'll try to do the same with standard router.

[chieffancypants]

No -- controller-based hotkeys are persistent by default, as they are used for things like a navigation bar which is present on every page. It's related to #32 but can be fixed by manually specifying that the hotkey is not intended to be persistent. This is the method signature:

/**
 * Creates a new Hotkey and creates the Mousetrap binding
 *
 * @param {string}   combo       mousetrap key binding
 * @param {string}   description description for the help menu
 * @param {Function} callback    method to call when key is pressed
 * @param {string}   action      the type of event to listen for (for mousetrap)
 * @param {array}    allowIn     an array of tag names to allow this combo in ('INPUT', 'SELECT', and/or 'TEXTAREA')
 * @param {boolean}  persistent  if true, the binding is preserved upon route changes
 */
function _add (combo, description, callback, action, allowIn, persistent) {

So simply pass in persistent: false in the object or function argument that you pass to hotkeys.add:

hotkeys.add({
  combo: 'w',
  description: '....',
  callback: function() {},
  persistent: false
});

[ujovlado]

I don't know how it happened, but it was browser-related issue ... in newer version it works fine. Thanks for help.