Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why using $parent[0].lastChild #179

Closed
giulioprovasi opened this issue Mar 3, 2015 · 8 comments
Closed

Why using $parent[0].lastChild #179

giulioprovasi opened this issue Mar 3, 2015 · 8 comments
Milestone

Comments

@giulioprovasi
Copy link

When trying to use a custom position for the loading bar, I must create two nested div in order for the bar to works (css are for demo only):

<div id="loader" style="position:absolute; background: #FC0; width: 100%; height:50px; top:100px;">
        <div style="background: #c3325f; width: 100%; height:50px; top:100px;"></div>
      </div>

as this won't work:

<div id="loader" style="position:absolute; background: #FC0; width: 100%; height:50px; top:100px;">
      </div>

Isn't it possible to append the bar to the currentSelector instead of parentSelector ?

@chieffancypants
Copy link
Owner

I'm not following the exact question, but the title of your issue is related to this commit: c21a146. Is this causing a problem?

@omeid
Copy link

omeid commented Mar 21, 2015

Yes, I have the same problem. It is now not possible to use an empty element for the parent.

Also, it would be nice if one could use a query selector or an actual dom/jqlite.element object on parentSelector instead of $document.find which is restricted to tag names only.

@chieffancypants
Copy link
Owner

I dont know -- that commit specifically was taken out of the Angular team's migration guide. Are you using an older version of angular?

@omeid
Copy link

omeid commented Mar 25, 2015

No, latest.

Can you maybe post an example where the loading bar is injected into an empty element? It doesn't show up for me at all if there is no element within the cfpLoadingBarProvider.parentSelector element.

@giulioprovasi
Copy link
Author

Sorry for late reply, as omeid explained well enough, I'd like to use a generic selector instead of the parentSelector, so that we can inject the loader in any empty container.

@joaovieira
Copy link
Contributor

I've pointed this out before. Just never got the time to write CoffeeScript tests.. #170 (comment)

@joaovieira
Copy link
Contributor

Added the PR: #218

@jklaus
Copy link
Contributor

jklaus commented Feb 8, 2016

See pull 272.

@chieffancypants chieffancypants added this to the next version milestone Feb 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants