@ngx-env/builder Mistargets File Path for index.server.html. ( Nx + Angular ) monorepo #77
Assignees
Labels
bug
Something isn't working
Comments
|
Thanks for detailing the issue. I was able to reproduce it. |
|
Fixed in 17.1.2, could you please test it? |
|
Note when using Nx: #47 (comment) |
|
@chihab Tested with version 17.1.2 and the issue is fixed. Thank you for the quick fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm currently facing an issue with @ngx-env/builder. During the build(production) process, an error shows up that says the builder couldn't find the file index.server.html. Here's the error message I'm getting:
and it just works! even with this error I can use .env and pass the env variable during the build :)
However, my index.server.html file seems to be correctly generated and is located on this path
After doing a bit of digging, it looks like the issue stems from how @ngx-env/builder is trying to construct the path to index.server.html. It seems to be basing this on our project's current working directory but is not correctly considering the output directory setting from the project.json file (which is dist/apps/client).
Here's the setting from the buildWithPlugin function in @ngx-env/builder/dist/builders/application/index.js:
(0, esbuild_index_html_1.indexHtml)((0, path_1.join)(cwd, options.outputPath.toString()), raw, !!options.ssr);From my understanding, the outcome of the above is
apps/client/dist/apps/clientbut according to our project.json, it should be justdist/apps/clientI'm not sure how to go about resolving this issue. If anyone has encountered a similar issue or has any guidance, it would be greatly appreciated.
additional details
folder tree sample
project.json
{ "name": "client", "$schema": "../../node_modules/nx/schemas/project-schema.json", "projectType": "application", "prefix": "org", "sourceRoot": "apps/client/src", "tags": [], "targets": { "build": { "executor": "@ngx-env/builder:application", "outputs": ["{options.outputPath}"], "options": { "allowedCommonJsDependencies": ["undici"], "outputPath": "dist/apps/client", "index": "apps/client/src/index.html", "browser": "apps/client/src/main.ts", "polyfills": ["zone.js"], "tsConfig": "apps/client/tsconfig.app.json", "inlineStyleLanguage": "scss", "assets": ["apps/client/src/favicon.ico", "apps/client/src/assets"], "styles": ["apps/client/src/styles.scss"], "scripts": [], "server": "apps/client/src/main.server.ts", "prerender": true, "ssr": { "entry": "apps/client/server.ts" } }, "configurations": { "production": { "budgets": [ { "type": "initial", "maximumWarning": "500kb", "maximumError": "2mb" }, { "type": "anyComponentStyle", "maximumWarning": "2kb", "maximumError": "4kb" } ], "outputHashing": "all" }, "development": { "optimization": false, "extractLicenses": false, "sourceMap": true, "fileReplacements": [ { "replace": "apps/client/src/environments/environment.ts", "with": "apps/client/src/environments/environment.development.ts" } ] } }, "defaultConfiguration": "production" }, "serve": { "executor": "@ngx-env/builder:dev-server", "configurations": { "production": { "buildTarget": "client:build:production" }, "development": { "buildTarget": "client:build:development" } }, "defaultConfiguration": "development", "options": { "proxyConfig": "apps/client/proxy.conf.json" } }, "extract-i18n": { "executor": "@ngx-env/builder:extract-i18n", "options": { "buildTarget": "client:build" } }, "lint": { "executor": "@nx/eslint:lint", "outputs": ["{options.outputFile}"] }, "test": { "executor": "@ngx-env/builder:karma", "outputs": ["{workspaceRoot}/coverage/{projectRoot}"], "options": { "jestConfig": "apps/client/jest.config.ts" } }, "serve-static": { "executor": "@nx/web:file-server", "options": { "buildTarget": "client:build", "staticFilePath": "dist/apps/client/browser" } } } }package.json
The text was updated successfully, but these errors were encountered: