Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question concerning weight initialization. #35

Closed
veritas9872 opened this issue Aug 18, 2019 · 0 comments
Closed

Question concerning weight initialization. #35

veritas9872 opened this issue Aug 18, 2019 · 0 comments

Comments

@veritas9872
Copy link

veritas9872 commented Aug 18, 2019

@ChihebTrabelsi In the current implementation of ComplexInit in init.py, the scale factor uses the following.
if self.criterion == 'glorot': s = 1. / (fan_in + fan_out) elif self.criterion == 'he': s = 1. / fan_in

However, it was my understanding from the paper that the s variable is the mode for the Rayleigh distribution and this mode should be set at s = 1./sqrt(fan_in +fan_out) and s = 1./sqrt(fan_out).

Please correct me if I am wrong, but doesn't this mean that the current implementation is missing a sqrt operation for the simple complex initialization?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant