You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@ChihebTrabelsi In the current implementation of ComplexInit in init.py, the scale factor uses the following. if self.criterion == 'glorot': s = 1. / (fan_in + fan_out) elif self.criterion == 'he': s = 1. / fan_in
However, it was my understanding from the paper that the s variable is the mode for the Rayleigh distribution and this mode should be set at s = 1./sqrt(fan_in +fan_out) and s = 1./sqrt(fan_out).
Please correct me if I am wrong, but doesn't this mean that the current implementation is missing a sqrt operation for the simple complex initialization?
The text was updated successfully, but these errors were encountered:
@ChihebTrabelsi In the current implementation of ComplexInit in init.py, the scale factor uses the following.
if self.criterion == 'glorot': s = 1. / (fan_in + fan_out) elif self.criterion == 'he': s = 1. / fan_in
However, it was my understanding from the paper that the
s
variable is the mode for the Rayleigh distribution and this mode should be set ats = 1./sqrt(fan_in +fan_out)
ands = 1./sqrt(fan_out)
.Please correct me if I am wrong, but doesn't this mean that the current implementation is missing a sqrt operation for the simple complex initialization?
The text was updated successfully, but these errors were encountered: