Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing cleanup for CADisplayLink #40

Closed
RolandasRazma opened this issue Apr 9, 2018 · 2 comments
Closed

missing cleanup for CADisplayLink #40

RolandasRazma opened this issue Apr 9, 2018 · 2 comments
Assignees
@chili-ios
Labels
bug

Comments

@RolandasRazma
Copy link

Correct me if I'm wrong but aren't you missing cleanup for CADisplayLink?
Shouldn't you at least .invalidate() it (probably remove from runloop also) before CHIBasePageControl is deallocated? Otherwise you risking of calling method on deallocated CHIBasePageControl
@chili-ios
Copy link
Contributor

hi @RolandasRazma ,
You are absolutely right. I'm going to fix it in next update.
Thank you for a bug report.

@chili-ios chili-ios self-assigned this Jul 3, 2018
@chili-ios chili-ios added the bug label Jul 3, 2018
@RolandasRazma
Copy link
Author

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chili-ios chili-ios

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RolandasRazma @chili-ios