Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPS request are blocked #32

Closed
nielsvangijzen opened this issue Oct 23, 2018 · 4 comments
Closed

HTTPS request are blocked #32

nielsvangijzen opened this issue Oct 23, 2018 · 4 comments

Comments

@nielsvangijzen
Copy link

Is it possible to expose the 443 port in order to test HTTPS routes?

@chilio chilio self-assigned this Oct 23, 2018
@chilio
Copy link
Owner

chilio commented Oct 24, 2018

Exposing 443 port is not sufficient for testing with HTTPS, although this is already done in :dev tag....
But Dusk testing will not work since WebServer in this package (NGINX) is not configured to handle SSL traffic and thus any communication via SSL will fail.
I am currently working on a solution for HTTPS testing, and it will be ready soon...

@nielsvangijzen
Copy link
Author

I already thought it wasn't going to be that easy, thanks for the effort though it would help me out a lot!

@chilio
Copy link
Owner

chilio commented Oct 29, 2018

Hey @nvangijzen here is what have been done so far in :dev image:

  1. 443 port is exposed
  2. Nginx configured with self signed certificate
  3. New driver args configured in DuskTestCase.php:
            '--disable-gpu',
            '--headless',
            '--no-sandbox',
            '--ignore-certificate-errors',
            '--start-maximized',
        ]);

But unfortunately dusk is not passing although wget https://localhost --no-check-certificate renders properly....

I will investigate it more in depth in some spare time....

@chilio
Copy link
Owner

chilio commented Nov 12, 2018

Unfotunately chromedriver argument --ignore-certificate-errors does not seem to work, which could enable us to proceed with self-signed certificates.
Testing your app without SSL, does not introduce any disadvantages in your dev environments.
Moreover you should test your app without https:// -> performance wise....
SSL termination is usually done by loadbalancers, so there is no need to doublecheck SSL functionality...
You can always embed SSL compliance, by installing proper SSL certificate, for certain site in nginx, using ubuntu commands in your .gitlab-yml.
Taking into consideration, notes obove, I am closing this issue....

@chilio chilio closed this as completed Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants