Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setRecord does not delete an existing record due to string mismatch #1

Closed
jrgm opened this issue Sep 17, 2013 · 0 comments
Closed

setRecord does not delete an existing record due to string mismatch #1

jrgm opened this issue Sep 17, 2013 · 0 comments

Comments

@jrgm
Copy link

jrgm commented Sep 17, 2013

You have a bug here - https://github.com/chilts/nice-route53/blob/master/nice-route53.js#L363-L385

The comparison is made between 'foo.bar.com' and 'foo.bar.com.' (with a trailing dot). So in trying to update an existing record, the DELETE is not done before the ADD in the changeset (which errors out).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jrgm