Skip to content
This repository has been archived by the owner on Apr 22, 2021. It is now read-only.

Changing the review model #229

Closed
phae opened this issue May 20, 2015 · 2 comments · Fixed by #289
Closed

Changing the review model #229

phae opened this issue May 20, 2015 · 2 comments · Fixed by #289
Assignees
@tmaybe
Milestone
Bootcamp

Comments

@phae
Copy link
Contributor

phae commented May 20, 2015

The button to send for review currently is just a mailto: anchor - it should send a post request or something so that there's actually a flag set (I think this must have existed once, but we can't work it out now). Needed for #116 and #89
@phae phae added this to the Bootcamp milestone May 20, 2015
@phae
Copy link
Contributor Author

phae commented May 29, 2015

Let's use this ticket to discuss what review status' we should have.

@phae phae mentioned this issue Jun 1, 2015
Closed
@phae phae changed the title Actually set review flags when a reviewer has been requested Changing the review model Jun 8, 2015
@phae
Copy link
Contributor Author

phae commented Jun 8, 2015

  • Being able to set the flag of an activity (and using it to render ui)
  • Change checkboxes to buttons
  • Requesting feedback, endorsing, publishing live in comment forms
  • Prepopulate email

@tmaybe tmaybe mentioned this issue Jun 25, 2015
Merged
norrishung pushed a commit that referenced this issue Jun 26, 2015
Merge branch 'implement-review-model-#229' of https://github.com/chim…
47d5a3f 
…ecms/chime into implement-review-model-#229
wpietri added a commit that referenced this issue Jun 26, 2015
@wpietri
Merge pull request #289 from chimecms/implement-review-model-#229
927af8e 
Implement review model #229
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tmaybe tmaybe

Labels
None yet
Projects
None yet
Milestone
Bootcamp
Development

Successfully merging a pull request may close this issue.

Implement review model #229 codeforamerica/chime
3 participants
@phae @wpietri @tmaybe