Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug in isInteractive #33

Open
dominikh opened this issue May 6, 2016 · 2 comments
Open

Possible bug in isInteractive #33

dominikh opened this issue May 6, 2016 · 2 comments

Comments

@dominikh
Copy link

dominikh commented May 6, 2016

The following line of code bitwise ORs os.ModeCharDevice with itself. This is either redundant, or meant to use another variable on the RHS:

return fileInfo.Mode()&(os.ModeCharDevice|os.ModeCharDevice) != 0
/src/github.com/ChimeraCoder/gojson/gojson/gojson.go:105:26: identical expressions on the left and right side of the '|' operator
@ChimeraCoder
Copy link
Owner

Thanks for catching this! @jmervine - do you happen to remember what you meant here?

@jmervine
Copy link
Contributor

jmervine commented May 9, 2016

I don't and am traveling out of the country on vacation for the next two weeks. I'd be happy to look when I get back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants