Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outputs invalid HOCON/JSON/YAML #174

Open
pauldraper opened this issue Jul 11, 2018 · 2 comments
Open

Outputs invalid HOCON/JSON/YAML #174

pauldraper opened this issue Jul 11, 2018 · 2 comments
Labels

Comments

@pauldraper
Copy link

pauldraper commented Jul 11, 2018

There is insufficient escaping of outputs.

Conversion example

regex: "[0-9]\.[0-9]*"

used to produce

{
  "regex": "[0-9]\\.[0-9]*"
}

but since #173 now produces malformed

{
  "regex": "[0-9]\.[0-9]*"
}

which is invalid.

The HOCON is probably invalid too (IDK), but in any case the Python API will have the same problem.

@darthbear darthbear added the bug label Aug 28, 2018
@bmartin-pan
Copy link

It looks like the json converter doesn't handle a lot of cases.

Compared to the Python json converter.

Is there a reason that the json module is not used?

@scottj97
Copy link
Contributor

Should this be closed now that #202 is merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants