Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved CI #78

Closed
dbrgn opened this issue Feb 14, 2019 · 3 comments
Closed

Improved CI #78

dbrgn opened this issue Feb 14, 2019 · 3 comments

Comments

@dbrgn
Copy link
Collaborator

dbrgn commented Feb 14, 2019

Hi @chinedufn, is it OK if I try to improve our CI pipeline by setting up https://circleci.com/ and splitting up the workflow?

@chinedufn
Copy link
Owner

@dbrgn absolutely! Anything that improves our CI is a 👍 in my book!

@dbrgn
Copy link
Collaborator Author

dbrgn commented Feb 16, 2019

Oh wow, the "run all tests" CircleCI build brings the build time from ~9-10 minutes (on TravisCI) down to around 3 minutes. And that's without much optimization. They use incredibly fast machines.

@chinedufn I have an initial version running on my fork. Could you maybe log in at https://circleci.com/add-projects/gh/chinedufn and add a new project for percy? I can't do it myself due to missing permissions.

Right now the tests work, but I'd like to split up unit tests and browser tests if possible. I also need to port over the gh-pages stuff. Maybe you could follow the steps here to create a deploy key, put it into CircleCI and register the public key in this GitHub repo? I'd only to know the fingerprint.

@chinedufn
Copy link
Owner

Woahhhhhh love it!

Done!

Here's the fingerprint 71:95:d0:f5:0d:f6:fe:2a:9d:62:d7:4e:9a:6f:8e:8d


Right now the tests work, but I'd like to split up unit tests and browser tests if possible.

If we're going from 10 minutes to 3 minutes I certainly have no complaints, but just curious about the thought process here so that I understand?


Nice!

@dbrgn dbrgn mentioned this issue Feb 16, 2019
@dbrgn dbrgn closed this as completed in #79 Feb 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants