-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved CI #78
Comments
@dbrgn absolutely! Anything that improves our CI is a 👍 in my book! |
Oh wow, the "run all tests" CircleCI build brings the build time from ~9-10 minutes (on TravisCI) down to around 3 minutes. And that's without much optimization. They use incredibly fast machines. @chinedufn I have an initial version running on my fork. Could you maybe log in at https://circleci.com/add-projects/gh/chinedufn and add a new project for percy? I can't do it myself due to missing permissions. Right now the tests work, but I'd like to split up unit tests and browser tests if possible. I also need to port over the gh-pages stuff. Maybe you could follow the steps here to create a deploy key, put it into CircleCI and register the public key in this GitHub repo? I'd only to know the fingerprint. |
Woahhhhhh love it! Done! Here's the fingerprint
If we're going from 10 minutes to 3 minutes I certainly have no complaints, but just curious about the thought process here so that I understand? Nice! |
Hi @chinedufn, is it OK if I try to improve our CI pipeline by setting up https://circleci.com/ and splitting up the workflow?
The text was updated successfully, but these errors were encountered: