Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

figure out why unique source files sometimes is only the test file - ignore those if possible #11

Closed
jmaher opened this issue Apr 4, 2016 · 3 comments

Comments

@jmaher
Copy link

jmaher commented Apr 4, 2016

here is a case where we only seem to have a unique source file of itself:
http://chinhodado.github.io/codecoverage_presenter/?buildRevision=232db2940e992fe4c998dbb0a498703fbf463e0d&query=2&select2=chrome%3A%2F%2Fmochitests%2Fcontent%2Fbrowser%2Faddon-sdk%2Ftest%2Fbrowser_sdk_loader_js_modules.js

in the test selection field if there is only lines covered from the test case itself (or I would argue any test related file), then we shouldn't show it.

The trick here is that we would need to run the query for all test files- this is the case to argue for adding more meta data into active data (post ingestion task)

@jmaher
Copy link
Author

jmaher commented Apr 11, 2016

this is confusing when you look at the query "given a source file which tests cover it" and the source file is the test file- lets fix this

@chinhodado
Copy link
Owner

Fixed. See #9.

@jmaher
Copy link
Author

jmaher commented Apr 25, 2016

yeah, this is nice!

@jmaher jmaher closed this as completed Apr 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants