-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed Popover goes out of screen #227
Comments
Any updates? |
Hi @chintan9 , |
Please fork my repo. Follow this https://github.com/chintan9/plyr-react#getting-started-for-development Raise the PR for master . You may use gitpod if you do not want to complicate your dev set up. Just click on https://gitpod.io/#https://github.com/chintan9/plyr-react |
Stale issue message |
@all-contributors please add @iamshouvikmitra for tests |
I've put up a pull request to add @iamshouvikmitra! 🎉 |
@all-contributors please add @iamshouvikmitra for User Testing and Bug reports |
I've updated the pull request to add @iamshouvikmitra! 🎉 |
@all-contributors please add @iamshouvikmitra for User Testing, tests and Bug reports |
I've put up a pull request to add @iamshouvikmitra! 🎉 |
Describe the bug
The popover that come when clicking on the setting icon in type: "audio", goes out of screen when placed at position that is close to the top of the screen.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
There should be a props for choosing the direction for the popover. Or the popover should have opened in downwards direction so that all options fit the screen
Screenshots
![Screenshot from 2020-05-31 18-44-04](https://user-images.githubusercontent.com/24479402/83353252-dbf1ac00-a36e-11ea-902d-e21c811454c0.png)
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: