Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed Popover goes out of screen #227

Closed
iamshouvikmitra opened this issue May 31, 2020 · 10 comments
Closed

Speed Popover goes out of screen #227

iamshouvikmitra opened this issue May 31, 2020 · 10 comments

Comments

@iamshouvikmitra
Copy link

iamshouvikmitra commented May 31, 2020

Describe the bug
The popover that come when clicking on the setting icon in type: "audio", goes out of screen when placed at position that is close to the top of the screen.
To Reproduce
Steps to reproduce the behavior:

  1. Go to 'https://react-vfptdd.stackblitz.io/'
  2. Click on 'Settings Icon'
  3. Click on 'Speed'
  4. See the options for selection goes out of the screen

Expected behavior
There should be a props for choosing the direction for the popover. Or the popover should have opened in downwards direction so that all options fit the screen

Screenshots
Screenshot from 2020-05-31 18-44-04

Desktop (please complete the following information):

  • OS: Ubuntu
  • Browser : Chrome
  • Version 83.0.4103.61 (Official Build) (64-bit)
@iamshouvikmitra
Copy link
Author

Any updates?

@iamshouvikmitra
Copy link
Author

Hi @chintan9 ,
Could you guide me to correct place so that I can generate a PR?

@chintan9
Copy link
Owner

Hi @iamshouvikmitra

Please fork my repo.

Follow this https://github.com/chintan9/plyr-react#getting-started-for-development

Raise the PR for master .

You may use gitpod if you do not want to complicate your dev set up. Just click on https://gitpod.io/#https://github.com/chintan9/plyr-react
login with github and raise pr against master

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2020

Stale issue message

@chintan9
Copy link
Owner

chintan9 commented Oct 1, 2020

@all-contributors please add @iamshouvikmitra for tests

@allcontributors
Copy link
Contributor

@chintan9

I've put up a pull request to add @iamshouvikmitra! 🎉

@chintan9
Copy link
Owner

chintan9 commented Oct 1, 2020

@all-contributors please add @iamshouvikmitra for User Testing and Bug reports

@allcontributors
Copy link
Contributor

@chintan9

I've updated the pull request to add @iamshouvikmitra! 🎉

@chintan9
Copy link
Owner

chintan9 commented Oct 1, 2020

@all-contributors please add @iamshouvikmitra for User Testing, tests and Bug reports

@allcontributors
Copy link
Contributor

@chintan9

I've put up a pull request to add @iamshouvikmitra! 🎉

@github-actions github-actions bot closed this as completed Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants