Complex coefficients are not read correctly from file

[chipmuenk]

CSV files with complex data is not read correctly, only the real part of the first row is read, further rows are discarded without warning.

[guillaumedavidphd]

I'd love to be able to load a complex filter, from CSV or any other format. At the moment everything is cast to float. I could help if you point me in the right direction.

[chipmuenk]

Thanks for reminding me of that issue :-) You're right, complex coefficients are parsed incorrectly not only in CSV format. However, saving complex coefficients works and poles / zeros (which usually are complex) are read back correctly. I updated the title accordingly.

Given that most of the functionality works, I hope that this bug is relatively easy to fix. I didn't know whether anyone needed this functionality so I focussed on other stuff. Unfortunately, I'm quite busy till the weekend but I'll try to give you a pointer then.
Your help is very appreciated!

The culprit might be one of the library routines pyfda_lib.fil_save() or pyfda.fil_convert() which convert sos <-> ba <-> PZ formats. If you like, you can start by checking these functions.

When fixing the complex import bug, I'll also look at another intermittent bug that occurs when switching between manual entry of IIR and FIR filters in the coefficient tab. And I'll take a look into saving coefficients in sos format which is another request.

[guillaumedavidphd]

What's the status on complex coefficients? You mentioned you would give me some pointer to get me started on this, but that was a while back. I'm still interested in helping if I can.

[chipmuenk]

I had thought it would be easier to solve this - unfortunately the coefficient widget handles fixpoint quanization as well, and in the process I've created a horribly entangled code. I would be interested in untangling this mess but this is really ugly.
You could take a look into input_widgets/input_coeffs.py and tell me what you think.

[guillaumedavidphd]

I had a look. Unfortunately I'm lacking the time to untangle the code. Somehow I though the effort would be less than what it is.