Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bak, docs, and recipe directories included in PyPI packages #235

Closed
ryanvolz opened this issue Jul 28, 2023 · 0 comments · Fixed by #236
Closed

bak, docs, and recipe directories included in PyPI packages #235

ryanvolz opened this issue Jul 28, 2023 · 0 comments · Fixed by #236

Comments

@ryanvolz
Copy link
Contributor

I'm looking to package pyfda for conda-forge so I can include it in radioconda, and I noticed that these extra directories were being included included in the PyPI source package (and thus also the wheel and my intended conda package). This looks like something you tried to clean up already, unfortunately unsuccessfully.

After poking around, it looks like doing prune bak, etc. instead of exclude bak in the MANIFEST.in will do the job. As for tests, if the intention is to exclude pyfda/tests, then I think you'll need to prefix it with pyfda/ as in prune pyfda/tests.


As for the conda package, I noticed that that was something that you used to do a few years ago but stopped because it was too much work. Fortunately, the tooling is nicer now and putting packages on the conda-forge community channel greatly lessens the maintenance burden. I don't mean to step on any toes, so if you're interested in co-maintaining the conda-forge packaging I would be happy to include you, or if you'd rather not be bothered then I'm happy to do it alone. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant