Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an outsource=true option when launching via ssh to go back to the terminal spawning approach #56

Closed
chipsenkbeil opened this issue Nov 2, 2021 · 1 comment
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@chipsenkbeil
Copy link
Owner

Due to problems with ssh2-rs and not being able to upgrade wezterm-ssh (see #48) right now, we need another way to execute DistantLaunch. Should do the old process of termopen(...) with an ssh command, reading the result to look for the DISTANT CONNECT -- <PORT> <KEY> and then running DistantConnect programmatically.

Will require DistantConnect to support supplying the key programmatically. Probably shouldn't expose this in the command but instead allow it as part of editor.connect(...).

@chipsenkbeil chipsenkbeil added the enhancement New feature or request label Nov 2, 2021
@chipsenkbeil chipsenkbeil added this to the v0.2 milestone Nov 2, 2021
@chipsenkbeil chipsenkbeil modified the milestones: v0.2.0, v0.3.0 May 15, 2023
@chipsenkbeil chipsenkbeil removed this from the v0.3.0 milestone Jun 26, 2023
@chipsenkbeil chipsenkbeil added the wontfix This will not be worked on label Jun 26, 2023
@chipsenkbeil
Copy link
Owner Author

We were able to upgrade to support libssh alongside ssh2-rs.

This is not an issue to be handled by the plugin, but instead upstream distant. I don't plan to re-add the ssh terminal option within the plugin.

What would be nice is the upstream chipsenkbeil/distant#193, which I'm hopeful would provide more stability in the pure SSH implementation of distant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant