Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compress request & response byte formats #198

Open
chipsenkbeil opened this issue Jun 11, 2023 · 0 comments
Open

Compress request & response byte formats #198

chipsenkbeil opened this issue Jun 11, 2023 · 0 comments
Labels
breaking Would require breaking changes refactor Refactor portions of codebase
Milestone

Comments

@chipsenkbeil
Copy link
Owner

We read keys from a msgpack map in order. We can translate this to an array instead where we still read in order, but this will reduce the byte size of our requests and responses.

  • Requests will shrink by 2 ("id") + 7 ("payload") + an optional 6 ("header"): 9 to 15 bytes.
  • Responses will shrink by 2 ("id") + 9 ("origin_id") + 7 ("payload") + an optional 6 ("header"): 18 to 24 bytes.
@chipsenkbeil chipsenkbeil added refactor Refactor portions of codebase breaking Would require breaking changes labels Jun 11, 2023
@chipsenkbeil chipsenkbeil added this to the 0.20 milestone Jun 11, 2023
@chipsenkbeil chipsenkbeil modified the milestones: 0.20, Backlog, 1.0 Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Would require breaking changes refactor Refactor portions of codebase
Projects
None yet
Development

No branches or pull requests

1 participant