Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support retry logic for clients #22

Closed
chipsenkbeil opened this issue Aug 13, 2021 · 3 comments
Closed

Support retry logic for clients #22

chipsenkbeil opened this issue Aug 13, 2021 · 3 comments
Labels
duplicate This issue or pull request already exists enhancement New feature or request

Comments

@chipsenkbeil
Copy link
Owner

For interactive clients, it would be useful to support retry logic versus immediate death when the network connection with the server is severed.

With UDP, there's no connection, so we don't worry about it. For TCP, there is a connection.

Note that running processes that are disconnected would also be killed by the server as part of connection cleanup.

@chipsenkbeil chipsenkbeil added the enhancement New feature or request label Aug 13, 2021
@chipsenkbeil chipsenkbeil added this to the Backlog milestone Aug 15, 2021
@chipsenkbeil chipsenkbeil modified the milestones: Backlog, 1.0 Oct 11, 2021
@chipsenkbeil
Copy link
Owner Author

Add a reconnect method to a session. The session internally keeps track of the host, port, and key it used (if distant) and does a new connect internally, replacing the transport. That or we need to create an entirely new session because all of the tasks die. Maybe we can do an initialize and then swap out all of the fields.

For ssh, we can support a reconnect method, but it will trigger the handler methods again.

@chipsenkbeil
Copy link
Owner Author

We now have a means to reconnect to a server versus launching, but the logic for retry will most likely live in the manager that is handling connections. There may need to be a heartbeat request/response type added, going from server -> client as to avoid a client spamming heartbeat requests.

This is now a duplicate of #107.

@chipsenkbeil chipsenkbeil added the duplicate This issue or pull request already exists label Jul 24, 2022
@chipsenkbeil chipsenkbeil modified the milestones: 1.0, 0.17 and earlier Aug 18, 2022
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant