Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fork-like experience for Windows #52

Closed
chipsenkbeil opened this issue Sep 17, 2021 · 3 comments
Closed

Support fork-like experience for Windows #52

chipsenkbeil opened this issue Sep 17, 2021 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed tests Related to adding, modifying, or removing tests

Comments

@chipsenkbeil
Copy link
Owner

When launching our server, we run distant listen --daemon ... to have the process detach from SSH and continue running. With Windows, there is no true fork that is reliable and fast. Instead, we will need to spawn a child process and pass all arguments (other than daemon). The child process will need to pipe back over stdout the credentials for the primary process to print out.

See https://stackoverflow.com/questions/52580384/fully-detach-childprocess-in-rust-on-windows for discussion. Seems like we need to run the process directly instead of via powershell or something else to ensure that it detaches and is not killed when the parent exits.

Other challenge is figuring out how to test this. We might need another CI just for Windows without WSL.

Blocks #51.

@chipsenkbeil chipsenkbeil added enhancement New feature or request help wanted Extra attention is needed tests Related to adding, modifying, or removing tests labels Sep 17, 2021
@chipsenkbeil chipsenkbeil added this to the 1.0 milestone Sep 17, 2021
@chipsenkbeil
Copy link
Owner Author

Potentially implemented in 16bed46, but not tested. Need a Windows machine to test, or create an automated test that can verify end-to-end on a Window Github runner.

@chipsenkbeil
Copy link
Owner Author

Successfully established a fork-like experience on windows that properly keeps the process around. It's on a branch that will eventually get merged.

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Extra attention is needed tests Related to adding, modifying, or removing tests
Projects
None yet
Development

No branches or pull requests

1 participant