Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add batch support to lua module #63

Closed
chipsenkbeil opened this issue Oct 18, 2021 · 3 comments
Closed

Add batch support to lua module #63

chipsenkbeil opened this issue Oct 18, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@chipsenkbeil
Copy link
Owner

While the module supports individual commands, we have not provided support for batching commands, which could be crucial to performance improvements. Batching is not exposed in SessionChannelExt, so we need to think through how to offer this in a way that is clean.

Current approach I can think of is to have a batch function that takes 1 or more RequestData and returns them, but this wouldn't be any better than using the session directly.

@chipsenkbeil chipsenkbeil added the enhancement New feature or request label Oct 18, 2021
@chipsenkbeil chipsenkbeil added this to the 1.0 milestone Oct 18, 2021
@chipsenkbeil
Copy link
Owner Author

It may just be easiest to have the lua module expose a batch async function that takes a list of method names and args and use that to recreate the request data, send a batch request using the session directly, and then map the responses back.

@chipsenkbeil
Copy link
Owner Author

No longer supporting lua library, but the cli now supports JSON batch.

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant