Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Add parsing support for Windows #89

Closed
chipsenkbeil opened this issue Nov 7, 2020 · 1 comment · Fixed by #128
Closed

Add parsing support for Windows #89

chipsenkbeil opened this issue Nov 7, 2020 · 1 comment · Fixed by #128
Labels
enhancement New feature or request refactoring Cleanup/changes that don't involve a new feature
Milestone

Comments

@chipsenkbeil
Copy link
Owner

In order to get some of our optimizations, we used memchr and variants to find linefeed characters (\n). This results in carriage returns (\r) not being captured to denote a newline such as with this example:

== some header ==\r\n
some paragraph of text

The header will fail as content parsed is == some header ==\r.

We need to go through our utility parsers and update all uses of the memchr to also cover carriage returns by checking for either \r or \n and, if finding \r checking to see if it is immediately followed by \n.

@chipsenkbeil chipsenkbeil added enhancement New feature or request refactoring Cleanup/changes that don't involve a new feature labels Nov 7, 2020
@chipsenkbeil chipsenkbeil added this to the backlog milestone Nov 7, 2020
@chipsenkbeil chipsenkbeil added this to To do in vimwiki-core via automation Nov 7, 2020
vimwiki-core automation moved this from To do to Done Nov 7, 2020
@chipsenkbeil chipsenkbeil reopened this Nov 7, 2020
vimwiki-core automation moved this from Done to In progress Nov 7, 2020
@chipsenkbeil chipsenkbeil moved this from In progress to To do in vimwiki-core Nov 7, 2020
@chipsenkbeil
Copy link
Owner Author

Easiest way would be to remove the checks for '\n' and instead use nom's newline function to scan for it. Should see what the slowdown is using timekeeper.

@chipsenkbeil chipsenkbeil modified the milestones: backlog, 0.1.0 Jun 5, 2021
vimwiki-core automation moved this from To do to Done Jun 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request refactoring Cleanup/changes that don't involve a new feature
Projects
vimwiki-core
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant