Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Rules for Packages #118

Closed
vinkla opened this issue Oct 11, 2015 · 7 comments
Closed

New Rules for Packages #118

vinkla opened this issue Oct 11, 2015 · 7 comments

Comments

@vinkla
Copy link
Contributor

vinkla commented Oct 11, 2015

New rules recently presented for this awesome list of awesome Laravel;

I have been inundated with a large number of pull requests after Taylor Otwell retweeted a link to this repo. Starting now, I will be adding links to the "Popular Packages" section, only if the package has received more than 200 stars on Github. Because of this pre-requisite, a lot of helpful packages will fall through the cracks – but I think this fair to everyone involved. Apologies for the inconvenience.

Instead I think the points below will make it easier to choose which packages that should be added to this list or not. IMO, the downloads count and/or the number of stars you've on GitHub doesn't say anything about how good the package. For example, your package isn't awesome if you don't have any tests.

Note that this is taken from http://thephpleague.com/

Started in #105.

@chiraggude
Copy link
Owner

This is a good starting point. Thanks for the help!

Now I lower the limit of Github stars required to get listed - Let's make it 100 stars.

@vinkla
Copy link
Contributor Author

vinkla commented Oct 11, 2015

I think we should lower it even more, maybe below 50? Lets take Laravel Fractal which is built by @freekmurze. That package is awesome, it follows all the guidelines above. Currently the package, at the time of this comment, has 34 downloads and 42 stars on GitHub. Keeping 100 stars would mean that package wouldn't make it on this list. Even though it is well written, well documented and is built by trusted Laravel developers who makes a lot of good packages for Laravel.

@arcanedev-maroc
Copy link
Contributor

Create a CONTRIBUTING.md file and put these rules in it.

@vinkla
Copy link
Contributor Author

vinkla commented Oct 11, 2015

@arcanedev-maroc That is a good idea 👍 We just need to discuss the rules first.

@chiraggude
Copy link
Owner

@arcanedev-maroc Yup! Will do this shortly.

@vinkla
Copy link
Contributor Author

vinkla commented Oct 11, 2015

@chiraggude I've created a pull request in #119

@fishmad
Copy link

fishmad commented Oct 16, 2015

Helpdesk and Ticket Support App
https://github.com/thekordy/ticketit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants