Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor Format line #1

Open
FichteFoll opened this issue Jan 27, 2019 · 6 comments
Open

Honor Format line #1

FichteFoll opened this issue Jan 27, 2019 · 6 comments

Comments

@FichteFoll
Copy link
Member

https://github.com/chireiden/python-ass/blob/a918e5980b2c565aad23681e3f741babebab2754/ass/document.py#L359-362

Nobody cares about it anyway

@stuxcrystal
Copy link

stuxcrystal commented Jan 27, 2019

Oh,

self.events_field_order = _Event.DEFAULT_FIELD_ORDER

That's unexpected

@stuxcrystal
Copy link

When looking at it closer, it seems, that there is no switch between SSA and ASS.
Their fields and field-order are subtly different.

Events (SSA)

Marked, Start, End, Style, Name, MarginL, MarginR, MarginV, Effect, Text

@FichteFoll
Copy link
Member Author

FichteFoll commented Jan 27, 2019

I intend to honor the format line but will default to the ASS one. SSA should also have a different header for the events in general and thus be distinguishable, but it's been a while.

Will take a look at the actual code some time later.

@FichteFoll FichteFoll changed the title Make Format line optional Honor Format line Feb 24, 2020
@FichteFoll
Copy link
Member Author

While some of the code has been rewritten for 0.5.0, we still don't actually read the format line and respect it for parsing the following fields.

@stuxcrystal
Copy link

I'll tell you two secrets.

  1. I'm alive.
  2. Nobody cares about the format line.

@FichteFoll
Copy link
Member Author

FichteFoll commented Feb 28, 2020

I know. I'm using this issue tracker to track issues with the library and this is a valid issue, albeit not an important one. I mean, I opened this issue in the first place (even though you reported it first).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants