Move gRPC to core #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for moving the code to core, rename Transport to RpcTransport.
penberg
force-pushed
the
penberg/move-grpc-to-core
branch
from
e335b57
to
a2737da
Compare
glommer
requested changes
Nov 29, 2021
| #[tokio::main] | ||
| async fn main() -> Result<()> { | ||
| let opt = Opt::from_args(); | ||
| let port = 50000 + opt.id; | ||
| let addr = format!("127.0.0.1:{}", port).parse().unwrap(); | ||
| let transport = Transport {}; | ||
| let transport = RpcTransport::new(Box::new(node_addr)); |
There was a problem hiding this comment.
I personally think it is better to have a single interface, Transport, that can take a trait so the user would write
Transport<RpcTransport>. This way we can have more code sharing between transports, and even allow the user to extend their transport more easily. For example, I want another RPC transport, but I want a specific verb to behave a bit differently
There was a problem hiding this comment.
Can you give me an example of what that single interface would look like? is Transport a struct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @glommer, let's move gRPC to core to make it easier for
users to embed ChiselStore out-of-the-box. Users can, of course, also
implement the necessary traits themselves if they don't want to use
gRPC.