Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: More graceful handling of policy code that can’t be optimized #1934

Open
CodingDoug opened this issue Dec 9, 2022 · 0 comments
Open

Feature: More graceful handling of policy code that can’t be optimized #1934

CodingDoug opened this issue Dec 9, 2022 · 0 comments
Assignees
@MarinPostma

Comments

@CodingDoug
Copy link
Contributor

Currently, if there is code present that can’t be optimized, such console.log(), chiseld will crash with a message:

thread 'tokio-runtime-worker' panicked at 'not yet implemented', chiselc/src/policies.rs:633:17

It would be an improvement to do one of these instead:

  • Crash with a more meaningful error message with the offending code/line
  • Ignore the offending code and continue without it, warning at the console
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarinPostma MarinPostma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CodingDoug @MarinPostma