PriorityQueue tests failing seemingly at random

[dobios]

The functionality tests for the priority queue have each been failing seemingly at random from one run to the next.
Sometimes MemoryTest fails, sometimes PriorityQueueTest fails, and sometimes they both pass...

This should be really made consistent, as it either shows that the functionality of the PriorityQueue is wrong, or that the test is wrong.

@tjarker Please look into this.

[tjarker]

will do!

[hansemandse]

Having been over the code quite thoroughly now, I believe this issue stems from calling scala.util.Random directly without a seed instead of instantiating and initializing one for subsequent use. As this is done on several occasions (in MemoryTest.scala, for example), the order the tests are executed in may affect whether they fail or not.

Unfortunately, a similar thing is done within the chiselverify.assembly component where fixing it might be a bit more troublesome.

[hansemandse]

Why was this closed? The issue still persists and it doesn't look great to keep having random red crosses in PRs and on the main branch.

[dobios]

I see that now, sorry I thought this had been solved