Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gfm-task-lists #111

Closed
1 of 5 tasks
leeoniya opened this issue Jan 17, 2013 · 6 comments
Closed
1 of 5 tasks

gfm-task-lists #111

leeoniya opened this issue Jan 17, 2013 · 6 comments

Comments

@leeoniya
Copy link

any interest in supporting gfm-tasks?

https://github.com/blog/1375-task-lists-in-gfm-issues-pulls-comments

- [ ] a task list item
- [ ] list syntax required
- [ ] normal **formatting**, @mentions, #1234 refs
- [x] incomplete
- [ ] completed
@walterdavis
Copy link

They're kinda meaningless without the back-end to support setting/unsetting them in a data store. Nice to look at, but that's about it.

Walter

On Jan 17, 2013, at 10:03 AM, Leon Sorokin wrote:

any interest in supporting gfm-tasks?

https://github.com/blog/1375-task-lists-in-gfm-issues-pulls-comments

@chjj
Copy link
Member

chjj commented Jan 17, 2013

See #107.

@chjj chjj closed this as completed Jan 17, 2013
@kindy
Copy link

kindy commented Nov 1, 2013

Hi @leeoniya , @chjj
does this feature implemented?
it's pretty useful.

I think we can just render
[ ] to <input type="checkbox" disabled>
and render
[x] to <input type="checkbox" disabled checked>

don't need to add any css class on input element.

how do you think?

@leeoniya
Copy link
Author

leeoniya commented Nov 1, 2013

I can only speak regarding my project, https://github.com/leeoniya/reMarked.js

As I mentioned here: #107 (comment) , I'd probably go with unicode entities, but having the option of input checkboxes would also work and probably more friendly from an HTML => markdown conversion perspective. It would be trivial to add support for both variations in reMarked.js.

This issue seems to be duped pretty often in marked and gets hung up on "there's no backend support" and "it's not standard" arguments, both of which I find moot.

@kindy
Copy link

kindy commented Nov 1, 2013

@leeoniya

I think the backend support is no need for this UI.
as most of us just want a "todo list" like things.

for the "not standard" stuff, as we already has gfm option, it's no matter to make it more "gfm".

if most people like it, it can become "standard" ...

btw. when I have time, I'll work on this feature. maybe this weekend.

and as other part is render to html, I think we can just render this to input element. but not unicode char.

:)

chjj added a commit that referenced this issue Feb 26, 2014
chjj added a commit that referenced this issue Mar 10, 2014
chjj added a commit that referenced this issue Mar 10, 2014
ghost pushed a commit to zergeborg/marked that referenced this issue May 13, 2016
ghost pushed a commit to zergeborg/marked that referenced this issue May 13, 2016
ghost pushed a commit to zergeborg/marked that referenced this issue May 13, 2016
ghost pushed a commit to zergeborg/marked that referenced this issue May 13, 2016
@jasondavis
Copy link

Is this featured added now?

@markedjs markedjs locked as resolved and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants