Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference links following lists are inlined #77

Closed
tlvince opened this issue Sep 18, 2012 · 5 comments
Closed

Reference links following lists are inlined #77

tlvince opened this issue Sep 18, 2012 · 5 comments

Comments

@tlvince
Copy link

tlvince commented Sep 18, 2012

Given the following document:

[link][1]

* List

  [1]: http://example.com

marked renders:

<p>[link][1]

</p>
<ul>
<li><p>List</p>
<p>[1]: http://example.com</p>
</li>
</ul>

... whereas I'd expect:

<p><a href="http://example.com">link</a></p>
<ul>
<li>List</li>
</ul>

GitHub's markdown parser seems to get it right (live preview):

link

  • List
@chjj
Copy link
Member

chjj commented Sep 19, 2012

Bah, good catch. This is actually a part of a trickier problem. There are some easy fixes for this, but none that actually replicate exact markdown.pl behavior. I really do want to replicate markdown.pl exactly here, but I'll have to find an efficient fix.

@chjj
Copy link
Member

chjj commented Jan 10, 2013

This was a little bit tricky to fix and I'm still not happy with it, but for now, this works: 48c6a43

@Mithgol
Copy link
Contributor

Mithgol commented Feb 19, 2013

The 48c6a43 commit does not seem to be ever merged to the master, and thus the latest npm-hosted marked (version 0.2.8) still does have this issue (if [1]: http://example.com is preceded by some whitespace).

Is that because you are still not happy enough with the fix?

@scottgonzalez
Copy link
Contributor

@chjj What's holding this up?

@lbdremy
Copy link

lbdremy commented Aug 20, 2013

+1 for this issue would be nice to have support for this. By the way thanks for the great work @chjj !

@chjj chjj closed this as completed in 48c6a43 Feb 21, 2014
ghost pushed a commit to zergeborg/marked that referenced this issue May 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants