Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not Handle Markdown Escapes In Link Href #829

Closed
mjbvz opened this issue Dec 6, 2016 · 3 comments · Fixed by #1135
Closed

Does not Handle Markdown Escapes In Link Href #829

mjbvz opened this issue Dec 6, 2016 · 3 comments · Fixed by #1135

Comments

@mjbvz
Copy link

mjbvz commented Dec 6, 2016

From microsoft/vscode#14968

Marked does not seem to properly handle markdown escapes inside of links. Only the link text itself is properly handled, the title and href are not:

var marked = require('marked');
marked('[text\\.](http://example\\.com "\\.title")')

produces:

<p><a href="http://example\.com" title="\.title">text.</a></p>
mjbvz added a commit to mjbvz/vscode that referenced this issue Dec 6, 2016
Fixes microsoft#14968

**Bug**
Due to markedjs/marked#829, markdown escapes inside of links are currently not rendered properly. This also can effect regular text that contains characters that are escaped when we convert them to markdown text.

**Fix**
For links, remove markdown escapes before rendering them.
@joshbruce
Copy link
Member

#984

@Feder1co5oave
Copy link
Contributor

Feder1co5oave commented Jan 10, 2018

Related to #229.
This is not limited to links, but more general.

Must review escaping of special and not-special characters via backslashes in various parts of the document. Should take a look at the escape inline rule, but some escaping problems exist in parts which are not inline-parsed, such as link titles.

http://spec.commonmark.org/0.28/#backslash-escapes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants