Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NixOS PR 236656 breaks squashfs support #1

Closed
chkno opened this issue Jul 21, 2023 · 1 comment · Fixed by #2 or #3
Closed

NixOS PR 236656 breaks squashfs support #1

chkno opened this issue Jul 21, 2023 · 1 comment · Fixed by #2 or #3

Comments

@chkno
Copy link
Owner

chkno commented Jul 21, 2023

NixOS/nixpkgs#236656 breaks squashfs support, in that it requires the nix store image to be mountable by label and squashfs doesn't support filesystem labels ( plougher/squashfs-tools#59 ).

@chkno
Copy link
Owner Author

chkno commented Jul 21, 2023

In practice, erofs doesn't help much: A 2.0G squashfs becomes an 8.1G ext4 or a 5.9G erofs image.

mkfs.erofs has flags for controlling compression settings. Some improvement is probably possible through messing with those.


A possible route to getting squashfs support back would be to patch the guest's kernel libblkid to add squashfs label support. It needn't be a high-quality patch that upstream would accept. For use cases that only mount one squashfs image, even a dreadful kludge that just hard-codes "nix-store" as the label for all squashfs filesystems would suffice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant