-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with using dynamic water level correction #289
Comments
@Jiangchao3 The |
@WPringle Thanks, I will have a try and let you know the result. |
Hi @WPringle, I use a datetime vector for time_interval, it works well.
But the offset time series in the generated offset.63 file still have been rounded: the following is the original offset data: I guess all the values less than 0.5 are rounded down to 0, while numbers greater than 0.5 are rounded up to 1. I look through the source code in writeoffset63, i thinkt he source code do not have any problem, but why the generated file have such a digital error? a bit confused. |
@WPringle in additon, how to understand the concept of if my bia correction period start from t1 = datetime(2017,9,6,1,0,0) and end at t2 = datetime(2017,9,12,0,0,0), so should I set dynamicWaterLevelCorrectionRampStart as the time t1 relative from the coldstart time or just give it one or two days to spin up for the dynamic water level correction like tidal rampup? I am not sure if I understand it correctly, although there is a example about it on https://wiki.adcirc.org/Dynamic_water_level_correction#Controlling_Water_Level_Correction |
@Jiangchao3 What do the values in msh.offset63 look like? The ramp is like the tidal ramp, just give it like a couple of days spinup. |
Hi @WPringle , in msh.offset63, the values is as following: |
how does |
Hi @WPringle ,Here is my msh object with offset63 and the original data for offset time series the following is my code to deal with the offset. %% Make dynamic water level offset file really appreciate with you for help check it out |
@Jiangchao3 I found the problem, it is a bit esoteric. When the You can see the fix in #287 |
clear,thanks very much @WPringle |
Hi @WPringle ,
I am trying to using the dynamic water level correction, met with two problems, the following is my code:
station=m.f15.elvstaloc; [idx,dst]=ourKNNsearch(m.p',station',1); time_vector=3600*[1:144]; offset_nodes=idx; offset_values=offset; m=Make_offset63(m,time_vector,offset_nodes,offset_values);
problem 1: How to appropriately set the time_vector?
the offset timeseries has 144 time step at 1 h intervels, I try to set time_vector = 3600*[1:144], time intervel is a duration, cause error when write the offset63 file:
when I set
m.offset63.time_interval = 3600;
, the error don't occur.problem 2: offset value in the generated offset.63 file is not corresponding to the value I give
the following is the offset timeseries I give:
but the offset value in the offset.63 value is as following:
Hope can get the feedback from you about how to correctly use it.
The text was updated successfully, but these errors were encountered: