Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binary sd-v0.7.6-x86_64-unknown-linux-musl is not compiled against musl in releases #153

Closed
CompuRoot opened this issue May 5, 2022 · 3 comments
Assignees
Labels
A-CI Area: Relating to CI M-needs triage Meta: Maintainer label me! P-linux Platform: Linux

Comments

@CompuRoot
Copy link

Both files are identical

https://github.com/chmln/sd/releases/download/v0.7.6/sd-v0.7.6-x86_64-unknown-linux-gnu
https://github.com/chmln/sd/releases/download/v0.7.6/sd-v0.7.6-x86_64-unknown-linux-musl

and compiled against gnu libc which makes it isn't portable as it used to be with musl

@mathomp4
Copy link

Just discovered this myself and was about to make a PR. Would be nice to fix this!

@CosmicHorrorDev CosmicHorrorDev self-assigned this May 12, 2023
@CosmicHorrorDev CosmicHorrorDev added A-CI Area: Relating to CI P-linux Platform: Linux M-needs triage Meta: Maintainer label me! labels May 17, 2023
@CosmicHorrorDev CosmicHorrorDev added this to the v0.8.0 Release milestone May 17, 2023
@yhakbar
Copy link
Contributor

yhakbar commented Aug 19, 2023

@CompuRoot

Do you think we can close out this issue? In my fork, I went ahead and published a release using the same CI we have here, and got different files for the gnu and musl builds:
https://github.com/yhakbar/sd/releases/tag/v0.7.7-yhakbar

I think it's likely that whatever CI issue caused this in the first place has been resolved.

@CompuRoot
Copy link
Author

@yhakbar

Yes, it looks like it compiled now correctly against musl, so let close the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI Area: Relating to CI M-needs triage Meta: Maintainer label me! P-linux Platform: Linux
Projects
None yet
Development

No branches or pull requests

4 participants