Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to document that sd does _not_ stream, loads entire input into memory #286

Open
corneliusroemer opened this issue Dec 23, 2023 · 2 comments

Comments

@corneliusroemer
Copy link

I was happy with sd until I noticed that it reads the entire input into memory. There's no streaming support at all.

This is mentioned in the following issues:

But I would expect this to be documented in the README, as it is a major caveat and limitation compared to standard sed.

@dev-ardi
Copy link
Contributor

Don't we mmap everything now? @nc7s

@nc7s
Copy link
Contributor

nc7s commented Dec 31, 2023

@dev-ardi:

Don't we mmap everything now? @nc7s

Stdin is still read in full into memory, it's then converted (wrapped?) to a mmap. See discussion in #287.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants