Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue headline/image/link etc. #25

Closed
nawalnew opened this issue Nov 1, 2017 · 11 comments
Closed

issue headline/image/link etc. #25

nawalnew opened this issue Nov 1, 2017 · 11 comments

Comments

@nawalnew
Copy link

nawalnew commented Nov 1, 2017

Hello,
I have an issue when selecting something else than headline.
When I click on Link than the same dropdown appears a s Headline "h1, h2, h3".

I don't know where the bug is.
Even when I try to hide the "headings" module, it appears.

Some advice?

My main.js
import wysiwyg from "vue-wysiwyg"; import "vue-wysiwyg/dist/vueWysiwyg.css"; Vue.use(wysiwyg, { hideModules: { headings: true } }); // config is optional. more below

@invmatt
Copy link

invmatt commented Nov 2, 2017

Having the same issue. In addition to this when selecting a heading the following error appears:

vueWysiwyg.js?5768:1 Uncaught TypeError: Cannot read property 'focus' of undefined
    at VueComponent.exec (vueWysiwyg.js?5768:1)
    at r.boundFn (vue.runtime.esm.js?ff9b:185)
    at r.l.emitEvent (vueWysiwyg.js?5768:1)
    at r.l.emit (vueWysiwyg.js?5768:1)
    at VueComponent.insertHeading (vueWysiwyg.js?5768:1)
    at boundFn (vue.runtime.esm.js?ff9b:186)
    at invoker (vue.runtime.esm.js?ff9b:1933)
    at HTMLButtonElement.fn._withTask.fn._withTask (vue.runtime.esm.js?ff9b:1768)

@rodrigoAbril
Copy link

rodrigoAbril commented Nov 2, 2017

Here is a demo of the bug
https://codesandbox.io/embed/jn0ovr2p9y

to replicate it just try adding a table

@rodrigoAbril
Copy link

@invmatt @nawalnew
if you upgrade vue to today's vue@2.5.3 release the problem is fixed

@invmatt
Copy link

invmatt commented Nov 6, 2017

@rodrigoAbril Confirmed. Updating has solved the problem. Thanks for the quick reply.

@rodrigoAbril
Copy link

well the issue is gone but now when you want to add a table you get this error:

ReferenceError
table is not defined
VueComponent.insertTable...

@chmln
Copy link
Owner

chmln commented Nov 7, 2017

Looks like changes in Vue are causing some errors.
Perhaps I could try rebuilding the library against the latest version.

@nawalnew
Copy link
Author

Same here, most issues fixed with update.
But cant create table -.-

@chmln
Copy link
Owner

chmln commented Nov 18, 2017

The version on master is now running against latest Vue without problems.
There will also be UX improvements and hopefully a fix for the link module.

Thanks all for your patience 👍

@chmln
Copy link
Owner

chmln commented Nov 22, 2017

Hi all,

I've published a new version under vue-wysiwyg@next at npm.
This version includes a fix for the hyperlink module, rewritten table module, usability improvements, and is built against the latest version of vue (2.5.8).

Please try it out and let me know if all the problems are fixed.

Thank you

@nawalnew
Copy link
Author

Thank you @chmln ,
It works better with all functionality.

I have just one Issue with multiple Instances of the editor and the tables.

Do you have an Idea how to solve this that I can use multiple Instances of the editor on one page? :)
bildschirmfoto 2017-11-24 um 10 10 51

@nawalnew nawalnew mentioned this issue Nov 24, 2017
@chmln
Copy link
Owner

chmln commented Nov 24, 2017

@nawalnew Yes, multiple instances will be available by next release :)

@chmln chmln closed this as completed Nov 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants