New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension is activated even if set to false #9
Comments
Thanks reporting the issue. i've just fixed this problem on development branch. |
Thanks for the reply, unfortunately I'm still having the issue. |
hmm, i might missed something. can you paste fully instruction:
above commands will be compile latest php-sundown and execute test cases. I've checked |
The make test pass successfully. My app contain a $config array containing all the available extensions with true or false. So I have an array like this :
If I pass this, all extensions set to false are not taken into account. I have to pass an array with only the true values. |
You can see here the complete class, I have two arrays (1 with the complete config, 1 with only the true values). The array to be passed in order to get it momently work is the https://github.com/kwattro/KwattroMarkdownBundle/blob/master/Parser/Parser.php |
And here the paste of the make test command :
|
Yes, it works because it momently use my second array which unset all false values. If you want the normal version, use branch beta1 instead. I'll try to add some phpunit tests. Thanks for the catch of the difference between config and parser. Nice evening |
@chobie I've completed refactored my code. it seems that everything is working fine now. just one thing i've seen today: it is not possible to change the renderer and the extensions configuration within the same instance. we have to create a new markdown instance if we want to change the renderer for eg. ? is it correct or i've missed something. |
@Kwattro Cheers! Yes, currently that needs to create a new instance. but that's too much. |
Ooooh nice, it would be a serious improvement. By the way, I use your php extension of your work (http://pecl.php.net/package/sundown) for the Travis test of my bundle but this does not reflect your last changes. If you intend to push your changes to the php extension also please let me know it. Thanks |
hey, i've just updated pecl release. now, you can install v0.2.0 via |
Hi,
First of all thanks for your work.
I've integrated your wrapper into a Symfony Bundle.
I have an issue when specifying the extensions to be activated, if I set an extension to false in the array passed to the Sundown\Markdown constructor, the extension is still activated.
This will still
autolink
the given var.Grtz
The text was updated successfully, but these errors were encountered: