#1 Fix a problem where plasma effect did not stop. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes the plasma effect will not stop rendering when the mouse moved is moved outside the notched area. Having a second display arranged above the notched laptop screen so that the cursor can exit the notch from the top side seems to be a (or the only) way to produce the problem. Debugging indicates that even though the expected `mouseExited(at:underNotch:)` method is called on `PlasmaEffect`, setting the `emitterCell.birthRate` to zero is not sufficient to stop the cell from rendering. Making sure to also update the `plasmaLayer.emitterPosition` value seems to be enough to get the birth rate change to take hold. This indicates that there is something unexpected happening in the emitterCell / Layer, which makes me think I'm just overlooking something. This does seem to work though and seems a safe change to make.
danielpunkass
approved these changes
Jan 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the plasma effect will not stop rendering when the mouse is moved outside the notched area. Having a second display arranged above the notched laptop screen so that the cursor can exit the notch from the top side seems to be a (or the only) way to produce the problem.
Debugging indicates that even though the expected
mouseExited(at:underNotch:)method is called onPlasmaEffect, setting theemitterCell.birthRateto zero is not sufficient to stop the cell from rendering. Making sure to also update theplasmaLayer.emitterPositionvalue seems to be enough to get the birth rate change to take hold. This indicates that there is something unexpected happening in the emitterCell / Layer, which makes me think I'm just overlooking something. This does seem to work though and seems a safe change to make.