Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments system to videos #51

Closed
tcitworld opened this issue Mar 19, 2017 · 3 comments
Closed

Add comments system to videos #51

tcitworld opened this issue Mar 19, 2017 · 3 comments

Comments

@tcitworld
Copy link
Collaborator

  • Subscribe system. When your server displays a video from another pod, it subscribes to the events of comments from this video. The original server then sends the events to servers which subscribed.

  • Original server must also get comments from other servers, so... Two way subscription system ?

@Chocobozzz Chocobozzz changed the title Comments Add comments system to videos Mar 20, 2017
@rigelk
Copy link
Collaborator

rigelk commented Dec 13, 2017

I know there is ongoing work to make the comment system ActivityPub-compatible, and my propositions don't interfere with it. They are mainly display/metrics features on the PeerTube instance(s).

As suggested by aluriak/@Aluriak:

We should allow to replace the comment system per-video in case the author wants extra features (i.e.: a link to a framapad, framacolibri, framaforms, arguman or framindmap). It would be so powerful for content producers that have punctual and specific needs (Q&A, challenge, debate, etc.).

To keep things simple, we should keep the traditional comment system working and advertise the link above, as a per-video (or series or video if we make that happen) override.

Why not let authors get comments as a file? It's so much simpler to count the number of participants to a game/competition in the comments with a text editor and Ctrl+f rather than with a web interface where you have to manually go through.

I don't agree with everything, but giving content creators a way to better communicate is definitely in the spirit of PeerTube. Give them a .csv (maybe capping to a size) for the simplest cases, and an API so that their fellow developer friends can build tools to help them deal with popularity.

A tree-like system as seen on reddit.com? A search by filter system on the comments ?

A way to display comments that has worked well in reddit is the tree-like display where comments that are up-voted the most are shown closer to the video. It could be the default display format based on the number of cumulated boosts/favorites, for instance, with a fallback on inverse chronological ordering.

Then, search of comments might be of lower priority, especially since it's only a display feature that is superseded by the aforementioned API/file comment retrieval.

@Chocobozzz
Copy link
Owner

Working branch: https://github.com/Chocobozzz/PeerTube/tree/feature/comments

I'll do a simple comment system first, and then we'll add your proposals in other issues @rigelk.

Main goal -> tree-like system (Mastodon, Reddit...):

  • A video has 0..n comment threads
  • Each thread has 1..n comments
  • A comment could be a reply to another comment

@Chocobozzz
Copy link
Owner

Implemented.

Demo: https://peertube.cpy.re/videos/watch/da2b08d4-a242-4170-b32a-4ec8cbdca701

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants