Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video views not matching the real number of views #6251

Closed
spirillen opened this issue Feb 27, 2024 · 10 comments
Closed

Video views not matching the real number of views #6251

spirillen opened this issue Feb 27, 2024 · 10 comments
Labels
Status: Waiting for answer Waiting issue author answer

Comments

@spirillen
Copy link

Describe the current behavior

I have for a long time been wondering why the video "views" counter isn't reflecting the actual number of views, but seems more like only showing the number of IP addresses visited divided by 10 is used as the number of views (I can see this as for sure have been seeing the same videos over 100 times, but the view counts are below one + from my weblog.

Steps to reproduce

  1. publish a video
  2. view it more than once
  3. Number of views are (if you are lucky) previous views ++1

Describe the expected behavior

I would expects the view counter grow by one for each views, this includes replays as the video obviously are views one more time.

Additional information

Any version I've had since 5.4

@Chocobozzz Chocobozzz changed the title Vidoe views not matching the real number of views Video views not matching the real number of views Feb 27, 2024
@Chocobozzz
Copy link
Owner

Hi,

Can you go on yourinstance.com/admin/system/debug and check if your IP is correctly detected by PeerTube?

@Chocobozzz Chocobozzz added the Status: Waiting for answer Waiting issue author answer label Feb 27, 2024
@spirillen
Copy link
Author

The real IP is detected as I did put up the realip in the nginx + I'm bypassing crimeflare

Sp for the test, I've tested over tor as well and here I get a different results... which is unexpected as this have work before...

I'm getting back on this issue when the IP issue is solved.

@spirillen
Copy link
Author

Hmm when using a VPN, the IP is the exit IP, only over tor this is different... So assuming the (proxy) setup is working

@Chocobozzz
Copy link
Owner

Can you try to reproduce with PeerTube debug logs enabled and paste them with:

  • The number of views you made (considering 1 address IP -> 1 view)
  • The number of views PeerTube displays (after a while since viewers are buffered)

You can also check interesting debug logs like Processing local view for to see what kind of IP PeerTube detects

@spirillen
Copy link
Author

Just to let you know I haven't forgotten this issue, just awaiting I get time to a minor disturbance in my force to pick it up

@spirillen
Copy link
Author

@Chocobozzz After the update to version 6.0.3 it seems the counter have start working, but that is leaving my other question or should we say request

The number of views you made (considering 1 address IP -> 1 view)

To make one view = one view... like if I have a stable IP, then none of my view would count as a view.

@Chocobozzz
Copy link
Owner

To make one view = one view... like if I have a stable IP, then none of my view would count as a view.

I'm sorry but I don't understand

@spirillen
Copy link
Author

spirillen commented Mar 30, 2024

The counter per video seems to be limited to only count one view per IP address that visit a video.

IF == TRUE; then...

My question is to make each Play count as a view, disregard IP address.

IE:

I've uploaded a Music Video, that I mysteriously happens to like and hit either F5 (+ ctrl)? or press the replay button, then I would expect the view counter to grow with one i++

@Chocobozzz
Copy link
Owner

Thanks for the explanations.

The counter per video seems to be limited to only count one view per IP address that visit a video

To be more specific, it's "The counter per video seems to be limited to only count one view per IP address that visit a video per hour"

You can reduce the per hour interval by updating the views.videos.ip_view_expiration setting: https://github.com/Chocobozzz/PeerTube/blob/develop/config/production.yaml.example#L382

@spirillen
Copy link
Author

Thanks, I most admit I never looked that deep into the config file :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Waiting for answer Waiting issue author answer
Projects
None yet
Development

No branches or pull requests

2 participants