-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More discreet "Incompatible browser" message #6284
Comments
Do you know what is the JS error that leads to this message? I think we should hide the angular application in such a scenario because we're not sure how the application will behave. |
No, unfortunately I'm not able to reproduce this.
Is the "Incompatible browser" message only shown when there's actually an error or does it only check the browser version? If it's the latter, isn't it better to just show a clear message that says something like "enter at your own risk" since it may work even though it's unsupported? |
Yes it's when there is an error (except to detect internet explorer). You can see the logic here: https://github.com/Chocobozzz/PeerTube/blob/develop/client/src/index.html#L70 |
Hi, Are you able to know which web browser and version has this kind of error? |
Hi, unfortunately I don't know in this specific case. I looked in Google Analytics to see which browser versions our TV users has been using for the last 90 days and found the following:
For the issue #3736 I know the user had Chrome 38 on a LG TV bought 2020. |
Describe the problem to be solved
A lot of smart TV's has old browsers installed and no easy way to update the browser. Today the "Incompatible browser" message takes a huge amount of area of the site which gives the user the feeling that's something is broken.
Describe the solution you would like
Even though the browser is old and it's not supported by Peertube it may still be working. Therefore I'd propose to have a clear message that explains that this browser is not supported, but you can continue on your own risk. A simple solution could be the one below, but it could be even more discreet.
The text was updated successfully, but these errors were encountered: