Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(kitty) Add "00" postfix to version #1310

Closed
wants to merge 1 commit into from

Conversation

Moredread
Copy link

@Moredread Moredread commented Aug 5, 2019

Description

Kitty uses the fourth version part. Add "00" so we can issue updates, in accordance with https://github.com/chocolatey/choco/wiki/CreatePackages#versioning-recommendations

How Has this Been Tested?

Ran update.ps1 locally

Screenshot (if appropriate, usually isn't needed):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Migrated package (a package has been migrated from another repository)

Checklist:

  • My code follows the code style of this repository.
  • My change requires a change to documentation (this usually means the notes in the description of a package).
  • I have updated the documentation accordingly (this usually means the notes in the description of a package).
  • All files are up to date with the latest Contributing Guidelines
  • The added/modified package passed install/uninstall in the chocolatey test environment.
  • The changes only affect a single package (not including meta package).

Kitty uses the fourth version part. Add "00" so we can issue updates.
@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

@Moredread Moredread mentioned this pull request Aug 5, 2019
@AdmiringWorm
Copy link
Member

Thank you for the interest of updating this package.
Unfortunately this change won't really do much, as a maintainer with write access to the repository would need to force the update instead (and using a helper to set the correct fix version).

I will be closing this PR, as I am almost ready with a few changes to the updater and will then force a new package update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants